[feat/#105] 인기 있는 책 조회 API, pr 코멘트 수정 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiminsong490
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
toPageDtoList랑 toPageDtoList2를 기존 방식대로 표현하면
toBookSearchResDtoPage와 BookSearchLikeResDtoPage 가 맞는거 같은데 너무 긴 것 같습니다
이거 어떻게 줄일 수 있을까요?
There was a problem hiding this comment.
저두 너무 긴것 같아서 일단 짧게 표현을 했는데 지금은 코드위에 주석으로 설명 넣어놓겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 기능 설명
redis와 연결이 되어 있는 상황이라서 여러명이 로컬에서 도커로 redis를 사용하면서 테스트를 진행하면 rds의 like 값이 이상하게 될 가능성이 있습니다.
pr 코멘트 수정 및 좋아요 api (get -> post) 수정하였습니다.
연결된 issue
close #105
✅ 체크리스트